Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upd: Support latest changes for Anyscale Operator on GCP #8

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

brent-anyscale
Copy link
Collaborator

@brent-anyscale brent-anyscale commented Nov 8, 2024

This matches latest requirements for GKE with recent changes to requirements for the Anyscale Operator.

On branch brent/gke-standard-public
Changes to be committed:
modified: README.md
modified: main.tf
modified: outputs.tf

Pull request checklist

Please check if your PR fulfills the following requirements:

  • pre-commit has been run
  • Tests for the changes have been added (for bug fixes / features)
  • All tests passing
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull Request Type

  • Bugfix
  • New feature
  • Refactoring (no functional changes)
  • Documentation change
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

On branch brent/gke-standard-public
Changes to be committed:
	modified:   README.md
	modified:   main.tf
	modified:   outputs.tf
@github-actions github-actions bot added documentation Improvements or additions to documentation examples labels Nov 8, 2024
Copy link

@brucez-anyscale brucez-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
nit: Shomil could double confirm if role/namespace/lb address changes are all deployed.

@brent-anyscale brent-anyscale merged commit bf5091c into main Nov 8, 2024
3 checks passed
@brent-anyscale
Copy link
Collaborator Author

lgtm. nit: Shomil could double confirm if role/namespace/lb address changes are all deployed.

Tested on troubleshooting org (Prod) with latest CLI. I suppose I should start noting minimal cli version in the docs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants