v1.18: Change DEFAULT_TPU_CONNECTION_POOL_SIZE to 1 (backport of #1014) #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 15f2dad)
CriesofCarrots
approved these changes
Apr 25, 2024
|
lgtm |
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…-xyz#1014) (anza-xyz#1043) Change DEFAULT_TPU_CONNECTION_POOL_SIZE to 1 (anza-xyz#1014) Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DEFAULT_TPU_CONNECTION_POOL_SIZE was set to 4 to maximize the performance when we do local performance testing with bench-tps. With the server side QOS restrictions per stake node and unstaked node, the benefit of more connections is less obvious while having more connections increase the load on the server especially during leader change.
This only change the default to 1. Validators still can use existing --tpu-connection-pool-size to override the default value.
Summary of Changes
Change DEFAULT_TPU_CONNECTION_POOL_SIZE to 1.
Fixes #
This is an automatic backport of pull request #1014 done by [Mergify](https://mergify.com).