Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverts back in SocketAddr dedup in retransmit stage #1106

Merged
merged 1 commit into from
May 7, 2024

Conversation

behzadnouri
Copy link

Problem

This was erronously deemed as unnecessary and removed in: #864

Summary of Changes

The commit partially reverts #864 and adds back socket-addr dedup.

This was erronously deemed as unnecessary and removed in:
anza-xyz#864

The commit partially reverts solana-labs#864 and adds back socket-addr dedup.
@behzadnouri behzadnouri force-pushed the revert-socket-addr-dedup branch from 5e79777 to b23f3d1 Compare April 29, 2024 19:13
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 82.2%. Comparing base (9f10f09) to head (b23f3d1).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #1106     +/-   ##
=========================================
- Coverage    82.2%    82.2%   -0.1%     
=========================================
  Files         880      880             
  Lines      235631   235643     +12     
=========================================
+ Hits       193718   193725      +7     
- Misses      41913    41918      +5     

@behzadnouri behzadnouri requested a review from t-nelson April 29, 2024 23:10
@behzadnouri
Copy link
Author

@t-nelson this is just a partial revert of the previous commit. can I get it reviewed?

@behzadnouri behzadnouri requested review from sakridge and removed request for t-nelson May 6, 2024 12:38
Copy link

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10's too many? 😉

@behzadnouri behzadnouri merged commit fbe1dbc into anza-xyz:master May 7, 2024
38 checks passed
@behzadnouri behzadnouri deleted the revert-socket-addr-dedup branch May 7, 2024 14:49
Copy link

mergify bot commented May 7, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request May 7, 2024
This was erronously deemed as unnecessary and removed in:
#864

The commit partially reverts #864 and adds back socket-addr dedup.

(cherry picked from commit fbe1dbc)
mergify bot added a commit that referenced this pull request May 14, 2024
… of #1106) (#1225)

reverts back in SocketAddr dedup in retransmit stage (#1106)

This was erronously deemed as unnecessary and removed in:
#864

The commit partially reverts #864 and adds back socket-addr dedup.

(cherry picked from commit fbe1dbc)

Co-authored-by: behzad nouri <behzadnouri@gmail.com>
anwayde pushed a commit to firedancer-io/agave that referenced this pull request Jul 23, 2024
… of anza-xyz#1106) (anza-xyz#1225)

reverts back in SocketAddr dedup in retransmit stage (anza-xyz#1106)

This was erronously deemed as unnecessary and removed in:
anza-xyz#864

The commit partially reverts anza-xyz#864 and adds back socket-addr dedup.

(cherry picked from commit fbe1dbc)

Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants