Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.18: adds api to obtain the parent node in the turbine retransmit tree (backport of #115) #135

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 7, 2024

This is an automatic backport of pull request #115 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Following commits will use this api to check retransmitter's signature
on incoming shreds.

(cherry picked from commit 42e8309)
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 79.77528% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 81.6%. Comparing base (50469ae) to head (0983d18).

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.18     #135     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         827      827             
  Lines      224302   224370     +68     
=========================================
+ Hits       183120   183148     +28     
- Misses      41182    41222     +40     

@behzadnouri behzadnouri requested a review from bw-solana March 7, 2024 19:31
@behzadnouri behzadnouri added the automerge automerge Merge this Pull Request automatically once CI passes label Mar 7, 2024
@bw-solana bw-solana requested a review from willhickey March 8, 2024 15:33
Copy link

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bw-solana
Copy link

Adding @willhickey for awareness

@mergify mergify bot merged commit d4678fc into v1.18 Mar 8, 2024
36 checks passed
@mergify mergify bot deleted the mergify/bp/v1.18/pr-115 branch March 8, 2024 15:34
anwayde pushed a commit to firedancer-io/agave that referenced this pull request Jul 23, 2024
…ree (backport of anza-xyz#115) (anza-xyz#135)

adds api to obtain the parent node in the turbine retransmit tree (anza-xyz#115)

Following commits will use this api to check retransmitter's signature
on incoming shreds.

(cherry picked from commit 42e8309)

Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants