Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update patch paths for tokio, crossbeam, and curve25519-dalek #1681

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

willhickey
Copy link

Problem

I moved these 3 repos from solana-labs to anza-xyz. We use those repos as patches.

  • curve25519-dalek
  • crossbeam
  • solana-tokio

Summary of Changes

Update the manifest to use the new locations

@willhickey willhickey requested a review from yihau June 11, 2024 04:16
Copy link

mergify bot commented Jun 11, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@willhickey
Copy link
Author

Looks like the redirects will be valid indefinitely, so maybe we skip the v1.18 backport. @yihau, do you have a preference here?
https://github.com/orgs/community/discussions/22669

@willhickey willhickey removed the v1.18 label Jun 11, 2024
@yihau
Copy link
Member

yihau commented Jun 11, 2024

I guess we can skip the bp. no one will create repos with the same names under solana-labs 🤞

@yihau yihau added the automerge automerge Merge this Pull Request automatically once CI passes label Jun 11, 2024
@mergify mergify bot merged commit ada1830 into anza-xyz:master Jun 11, 2024
54 checks passed
@yihau
Copy link
Member

yihau commented Jun 11, 2024

I changed my mind haha. I guess bp is harmless. let's do it and see what others think!

@yihau yihau added the v1.18 label Jun 11, 2024
Copy link

mergify bot commented Jun 11, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Jun 11, 2024
Update patch paths after moving the forks of tokio, crossbeam, and curve25519-dalek to anza-xyz

(cherry picked from commit ada1830)
yihau pushed a commit that referenced this pull request Jun 11, 2024
…(backport of #1681) (#1683)

Update patch paths for tokio, crossbeam, and curve25519-dalek (#1681)

Update patch paths after moving the forks of tokio, crossbeam, and curve25519-dalek to anza-xyz

(cherry picked from commit ada1830)

Co-authored-by: Will Hickey <csu_hickey@yahoo.com>
anwayde pushed a commit to firedancer-io/agave that referenced this pull request Jul 23, 2024
…(backport of anza-xyz#1681) (anza-xyz#1683)

Update patch paths for tokio, crossbeam, and curve25519-dalek (anza-xyz#1681)

Update patch paths after moving the forks of tokio, crossbeam, and curve25519-dalek to anza-xyz

(cherry picked from commit ada1830)

Co-authored-by: Will Hickey <csu_hickey@yahoo.com>
samkim-crypto pushed a commit to samkim-crypto/agave that referenced this pull request Jul 31, 2024
…yz#1681)

Update patch paths after moving the forks of tokio, crossbeam, and curve25519-dalek to anza-xyz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes v1.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants