Updates static assert of cache hash data Header size #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The account hash cache data file contains a header with the number of entries in the file. The count itself is a usize. Since we are writing this to disk, we annotate the struct with
repr(C), butusizedoes not have a fixed binary size. If somehow we tried to mix a 32-bit and 64-bit system, the header's count would be interpreted wrong.Summary of Changes
Add a static assert that the size of the header is 8 bytes.
This is an easy fix to ensure binary compatibility is not broken, and doesn't require refactoring types more broadly (which can still be done in a subsequent PR).