Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Pubkey::to_bytes as constexpr #220

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

ripatel-fd
Copy link

Problem

Cannot do compile-time tricks with static const pubkeys

Summary of Changes

Adds support for constexprs

Fixes #

@mergify mergify bot requested a review from a team March 13, 2024 05:18
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (e682fec) to head (6109c3e).

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #220     +/-   ##
=========================================
- Coverage    81.9%    81.8%   -0.1%     
=========================================
  Files         837      837             
  Lines      226539   226539             
=========================================
- Hits       185548   185534     -14     
- Misses      40991    41005     +14     

Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This will definitely help, and for anyone else who ends up reading this, we can't do this with a From trait because const traits aren't stable in Rust yet.

@joncinque joncinque merged commit 9b16df2 into anza-xyz:master Mar 13, 2024
47 checks passed
@ripatel-fd ripatel-fd deleted the patch-1 branch March 13, 2024 17:10
HardhatChad pushed a commit to HardhatChad/agave that referenced this pull request Apr 28, 2024
@t-nelson t-nelson added the v1.18 label Apr 29, 2024
Copy link

mergify bot commented Apr 29, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Apr 29, 2024
joncinque pushed a commit that referenced this pull request May 4, 2024
sdk: support Pubkey::to_bytes as constexpr (#220)

(cherry picked from commit 9b16df2)

Co-authored-by: ripatel-fd <ripatel+git@jumptrading.com>
anwayde pushed a commit to firedancer-io/agave that referenced this pull request Jul 23, 2024
… (anza-xyz#1107)

sdk: support Pubkey::to_bytes as constexpr (anza-xyz#220)

(cherry picked from commit 9b16df2)

Co-authored-by: ripatel-fd <ripatel+git@jumptrading.com>
codebender828 pushed a commit to codebender828/agave that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants