-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Pubkey::to_bytes as constexpr #220
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #220 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 837 837
Lines 226539 226539
=========================================
- Hits 185548 185534 -14
- Misses 40991 41005 +14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! This will definitely help, and for anyone else who ends up reading this, we can't do this with a From
trait because const traits aren't stable in Rust yet.
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
(cherry picked from commit 9b16df2)
… (anza-xyz#1107) sdk: support Pubkey::to_bytes as constexpr (anza-xyz#220) (cherry picked from commit 9b16df2) Co-authored-by: ripatel-fd <ripatel+git@jumptrading.com>
Problem
Cannot do compile-time tricks with static const pubkeys
Summary of Changes
Adds support for constexprs
Fixes #