Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: manual_inspect #2496

Merged
merged 1 commit into from
Aug 9, 2024
Merged

clippy: manual_inspect #2496

merged 1 commit into from
Aug 9, 2024

Conversation

yihau
Copy link
Member

@yihau yihau commented Aug 8, 2024

(part of #2487 )

Problem

Screenshot 2024-08-08 at 22 27 54

https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect

Summary of Changes

  • replace map with inspect when possible
  • replace map_err with inspect_err when possible

@yihau yihau marked this pull request as ready for review August 8, 2024 16:36
@yihau yihau requested review from brooksprumo and steviez August 8, 2024 16:37
steviez
steviez approved these changes Aug 8, 2024
View reviewed changes
Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yihau yihau merged commit 4ac1300 into anza-xyz:master Aug 9, 2024
40 checks passed
@yihau yihau deleted the map-inspect branch August 9, 2024 07:10
@yihau yihau mentioned this pull request Aug 11, 2024
Merged
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
@yihau @ray-kast
clippy: manual_inspect (anza-xyz#2496)
7dab71f 
fix manual_inspect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviez steviez steviez approved these changes

@brooksprumo brooksprumo brooksprumo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihau @brooksprumo @steviez