Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove disable_block_production_forwarding cli flag #2687

Merged
merged 1 commit into from
Aug 26, 2024
Merged

remove disable_block_production_forwarding cli flag #2687

merged 1 commit into from
Aug 26, 2024

Conversation

apfitzge
Copy link

Problem

  • Flag adds operational complexity
  • If operators see issue(s) with staked partner forwarding, they should remove staked-partner configuration.

Summary of Changes

  • Remove disable-block-production-forwarding cli flag from validator

Fixes #

@apfitzge apfitzge marked this pull request as ready for review August 21, 2024 18:02
@apfitzge apfitzge requested review from t-nelson and steviez August 21, 2024 18:03
@apfitzge apfitzge self-assigned this Aug 21, 2024
@apfitzge
Copy link
Author

As discussed for backport of #1801 (#2285), this should be backported if #2285 gets merged.

steviez
steviez approved these changes Aug 23, 2024
View reviewed changes
Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and given that the flag doesn't exist in any release branch, no need for CHANGELOG entry

@apfitzge apfitzge merged commit df892c4 into anza-xyz:master Aug 26, 2024
40 checks passed
@apfitzge apfitzge deleted the forwarding_cli_arg branch August 26, 2024 12:53
@apfitzge apfitzge mentioned this pull request Aug 26, 2024
Merged
@apfitzge apfitzge added the v2.0 Backport to v2.0 branch label Sep 12, 2024
@mergify Mergify
Copy link

mergify bot commented Sep 12, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Sep 12, 2024
@apfitzge @mergify
remove disable_block_production_forwarding cli flag (#2687)
26d249b 
(cherry picked from commit df892c4)
@mergify mergify bot mentioned this pull request Sep 12, 2024
Merged
apfitzge added a commit that referenced this pull request Sep 12, 2024
@mergify @apfitzge
v2.0: remove disable_block_production_forwarding cli flag (backport of …
1b5c614 
…#2687) (#2909)

remove disable_block_production_forwarding cli flag (#2687)

(cherry picked from commit df892c4)

Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
@apfitzge @ray-kast
remove disable_block_production_forwarding cli flag (anza-xyz#2687)
73cb0b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviez steviez steviez approved these changes

@t-nelson t-nelson Awaiting requested review from t-nelson

Assignees

@apfitzge apfitzge

Labels
v2.0 Backport to v2.0 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apfitzge @steviez