-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: skip no-op program buffer writes #277
Conversation
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
12e5f66
to
db27328
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #277 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 837 837
Lines 226539 226557 +18
=========================================
- Hits 185548 185534 -14
- Misses 40991 41023 +32 |
cli: skip no-op program deploy write txs (cherry picked from commit 2c12500)
cli: skip no-op program deploy write txs
Problem
When retrying a program deploy, a buffer account might have already been partially written to but the cli program deployer will try to write the entire buffer again, wasting time and transactions.
Summary of Changes
Fixes #