Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: skip no-op program buffer writes #277

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

jstarry
Copy link

@jstarry jstarry commented Mar 16, 2024

Problem

When retrying a program deploy, a buffer account might have already been partially written to but the cli program deployer will try to write the entire buffer again, wasting time and transactions.

Summary of Changes

  • Before pushing a buffer write transaction, first check if the buffer data is already written with the desired data

Fixes #

Copy link

mergify bot commented Mar 16, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@jstarry jstarry force-pushed the cli/skip-noop-writes branch from 12e5f66 to db27328 Compare March 16, 2024 15:17
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 22.22222% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 81.8%. Comparing base (e682fec) to head (db27328).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #277     +/-   ##
=========================================
- Coverage    81.9%    81.8%   -0.1%     
=========================================
  Files         837      837             
  Lines      226539   226557     +18     
=========================================
- Hits       185548   185534     -14     
- Misses      40991    41023     +32     

@jstarry jstarry merged commit 2c12500 into anza-xyz:master Mar 18, 2024
33 checks passed
@jstarry jstarry deleted the cli/skip-noop-writes branch March 18, 2024 23:28
mergify bot pushed a commit that referenced this pull request Mar 18, 2024
cli: skip no-op program deploy write txs
(cherry picked from commit 2c12500)
anwayde pushed a commit to firedancer-io/agave that referenced this pull request Jul 23, 2024
codebender828 pushed a commit to codebender828/agave that referenced this pull request Oct 3, 2024
cli: skip no-op program deploy write txs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants