accounts-db: unpack_archive: unpack accounts straight into their final destination #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandrod
force-pushed
the
unpack-accounts-no-rename
branch
3 times, most recently
from
8a446e5 to
c9ae0cd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #289 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 837 837
Lines 226874 226891 +17
=======================================
+ Hits 185870 185884 +14
- Misses 41004 41007 +3 |
apfitzge
previously approved these changes
Mar 18, 2024
alessandrod
force-pushed
the
unpack-accounts-no-rename
branch
from
c9ae0cd to
dc517e5
Compare
Thanks for the review! Applied both suggestions. |
Aghh, looks like clippy didn't like the match I provided and asked you to do a |
alessandrod
force-pushed
the
unpack-accounts-no-rename
branch
from
dc517e5 to
a2f4ec0
Compare
Oops, fixed |
alessandrod
force-pushed
the
unpack-accounts-no-rename
branch
from
a2f4ec0 to
9d3c754
Compare
We used to do a iterator.clone().any(...) followed by iterator.collect(). Merge the two and avoid an extra iteration and re-parsing of the path.
…l destination We used to unpack accounts into account_path/accounts/<account> then rename to account_path/<account>. We now unpack them into their final destination directly and avoid the rename syscall.
alessandrod
force-pushed
the
unpack-accounts-no-rename
branch
from
9d3c754 to
399e17f
Compare
apfitzge
approved these changes
Mar 19, 2024
codebender828
pushed a commit
to codebender828/agave
that referenced
this pull request
Oct 3, 2024
…l destination (anza-xyz#289) * accounts-db: unpack_archive: avoid extra iteration on each path We used to do a iterator.clone().any(...) followed by iterator.collect(). Merge the two and avoid an extra iteration and re-parsing of the path. * accounts-db: unpack_archive: unpack accounts straight into their final destination We used to unpack accounts into account_path/accounts/<account> then rename to account_path/<account>. We now unpack them into their final destination directly and avoid the rename syscall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to unpack accounts into account_path/accounts/ then rename to account_path/. We now unpack them into their final destination directly and avoid the rename syscall. I've added a test and verified that it behaves the same with both old and new impl.
I also removed an extra parsing/iteration over entry paths which was unnecessary.
See discord conversation for context https://discord.com/channels/428295358100013066/838890116386521088/1217386980292427786