Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Corrected the derivation command format #2952

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

0xAsten
Copy link

@0xAsten 0xAsten commented Sep 19, 2024

Problem

The command for generating a public key is incorrectly formatted, leading to errors when users try to generate keys using the provided syntax.

Here is what I got when execute that example command on Mac terminal:

solana-keygen pubkey prompt://?key=0/1
zsh: no matches found: prompt://?key=0/1

Summary of Changes

Corrected the command syntax.

Fixes #

@mergify mergify bot requested a review from a team September 19, 2024 08:59
@jstarry
Copy link

jstarry commented Sep 23, 2024

@yihau do you know how these docs changes are published? I'm not really sure anymore

@yihau
Copy link
Member

yihau commented Sep 23, 2024

iirc bp to beta channel will trigger the pipeline. cc @willhickey

@jstarry jstarry added the CI Pull Request is ready to enter CI label Sep 23, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Sep 23, 2024
@jstarry jstarry added the v2.0 Backport to v2.0 branch label Sep 23, 2024
Copy link

mergify bot commented Sep 23, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@willhickey willhickey merged commit d2cc71f into anza-xyz:master Sep 27, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Sep 27, 2024
@willhickey
Copy link

This PR's change to master will publish to https://edge.docs.anza.xyz/cli/wallets/paper

The v2.0 backport will publish to docs.anza.xyz and and beta.docs.anza.xyz. A v1.18 backport would publish to stable.docs.anaz.xyz but I'm not going to bother... since v1.18 is nearly EOL

willhickey pushed a commit that referenced this pull request Sep 27, 2024
#3005)

Fix: Corrected the derivation command format (#2952)

(cherry picked from commit d2cc71f)

Co-authored-by: Asten <dandelionlion@protonmail.com>
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants