ci: ignore the tonic audit as a temporary stopgap #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2501babe
approved these changes
Oct 2, 2024
joncinque
added a commit
to joncinque/solana-program-library
that referenced
this pull request
Oct 2, 2024
#### Problem Similar to anza-xyz/agave#3052, we need to ignore the RUSTSEC advisory on tonic until it's resolved upstream. #### Summary of changes Ignore the tonic advisory.
joncinque
added a commit
to solana-labs/solana-program-library
that referenced
this pull request
Oct 2, 2024
#### Problem Similar to anza-xyz/agave#3052, we need to ignore the RUSTSEC advisory on tonic until it's resolved upstream. #### Summary of changes Ignore the tonic advisory.
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
mergify bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
(cherry picked from commit 9b5525d) # Conflicts: # ci/do-audit.sh
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I'm too naive. #3050 will take some time to upgrade. use this quick fix for unblocking master asap
Summary of Changes
ignore tonic audit report temporarily