Supports accounts lt hash in snapshots #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
commented
Oct 7, 2024
runtime/src/bank/serde_snapshot.rs
Outdated
| @@ -546,7 +578,7 @@ mod tests { | |||
| #[cfg_attr( | |||
| feature = "frozen-abi", | |||
| derive(AbiExample), | |||
| frozen_abi(digest = "8hwm4YsQXJWGZdp762SkJnDok29LXKwFtmW9oQ2KSzrN") | |||
| frozen_abi(digest = "CKb4Lp4AEJKBCLqHCFSSsntQU3MpcphA38RcAXASeDuG") | |||
There was a problem hiding this comment.
The digest changed here because we've added the accounts lt hash to the snapshot.
Here's a diff from the ABI export files:
[snipped; above is all the same]
field accounts_lt_hash: core::option::Option<solana_runtime::serde_snapshot::types::SerdeAccountsLtHash>
enum Option (variants = 2)
variant(0) None (unit)
variant(1) Some(solana_runtime::serde_snapshot::types::SerdeAccountsLtHash) (newtype)
struct SerdeAccountsLtHash(solana_runtime::serde_snapshot::types::_::<impl serde::ser::Serialize for solana_runtime::serde_snapshot::types::SerdeAccountsLtHash>::serialize::__SerializeWith) (newtype)
tuple (elements = 1024)
element serde_with::ser::SerializeAsWrap<u16, serde_with::Same>
primitive u16
[snipped; this is repeated for all 1024 elements]
(Note: The digest in the PR now is different because the original/master digest has also changed. The changes in the ABI are still the same as described in this comment though.)
brooksprumo
commented
Oct 7, 2024
frozen abi diff
```
field accounts_lt_hash: core::option::Option<solana_runtime::serde_snapshot::types::SerdeAccountsLtHash>
enum Option (variants = 2)
variant(0) None (unit)
variant(1) Some(solana_runtime::serde_snapshot::types::SerdeAccountsLtHash) (newtype)
struct SerdeAccountsLtHash(solana_runtime::serde_snapshot::types::_::<impl serde::ser::Serialize for solana_runtime::serde_snapshot::types::SerdeAccountsLtHash>::serialize::__SerializeWith) (newtype)
tuple (elements = 1024)
element serde_with::ser::SerializeAsWrap<u16, serde_with::Same>
primitive u16
```
HaoranYi
reviewed
Oct 29, 2024
| @@ -662,6 +666,7 @@ impl BankFieldsToSerialize { | |||
| is_delta: bool::default(), | |||
| accounts_data_len: u64::default(), | |||
| versioned_epoch_stakes: HashMap::default(), | |||
| accounts_lt_hash: Some(AccountsLtHash(LtHash([0x7E57; LtHash::NUM_ELEMENTS]))), | |||
There was a problem hiding this comment.
does it have any special meaning for 7e57?
There was a problem hiding this comment.
This is my approximation for "TEST" 😸
HaoranYi
reviewed
Oct 29, 2024
Yes, the lt hash will go in the snapshot. Both when the feature is enabled, or if the cli arg is set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The accounts lt hash is not in snapshots, so it must always be regenerated. While testing, this is kinda OK, but when the real feature is enabled, that won't be sufficient.
Summary of Changes
Serialize and deserialize the accounts lt hash from snapshots. But only if the CLI arg is passed in (as there's not a feature-gate yet). This let's us get testing/runtime on startup asap.