-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clap-v3-utils] Remove deprecated functions #313
[clap-v3-utils] Remove deprecated functions #313
Conversation
…, `try_pubkey_of`, and `try_pubkeys_of`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated tags need updating. Otherwise I am okay with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wfm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #313 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 837 837
Lines 226874 226950 +76
=======================================
+ Hits 185855 185925 +70
- Misses 41019 41025 +6 |
Problem
Solana cla-v3-utils still uses deprecated functions from clap-v2.
Summary of Changes
Clap-v3 has a feature deprecated that, when included, gives warnings on deprecated functions. With this PR, all the deprecated functions should either be removed or explicitly allowed (on deprecated functions). However, if I include the deprecated feature, it seems to turn this feature on in the rest of the repo on CI checks, so I left it out for now.
This is a port of solana-labs#34989.
Fixes #