Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler: Improve TTL #3161

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Scheduler: Improve TTL #3161

merged 2 commits into from
Oct 15, 2024

Conversation

apfitzge
Copy link

Problem

  • Scheduler tracks the end of epoch slot so that transactions are re-sanitized if the epoch rolls over
  • Does not tell us when ALTs may expire

Summary of Changes

  • track when ALTs expire to avoid re-checking ALT resolution every time
  • re-resolve if the ALT expiration is hit

Fixes #

@apfitzge apfitzge marked this pull request as ready for review October 14, 2024 22:19
@apfitzge apfitzge requested a review from jstarry October 14, 2024 22:19
accounts-db/src/accounts.rs Outdated Show resolved Hide resolved
runtime/src/bank/address_lookup_table.rs Outdated Show resolved Hide resolved
jstarry
jstarry previously approved these changes Oct 14, 2024
Copy link

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, definitely not great that we were reloading ALTs after just doing that work in the scheduler.. can we backport this to v2.0?

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
@apfitzge apfitzge self-assigned this Oct 15, 2024
@apfitzge apfitzge requested a review from jstarry October 15, 2024 13:34
@apfitzge apfitzge added the v2.0 Backport to v2.0 branch label Oct 15, 2024
Copy link

mergify bot commented Oct 15, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@apfitzge apfitzge merged commit 7b0a573 into anza-xyz:master Oct 15, 2024
51 checks passed
mergify bot pushed a commit that referenced this pull request Oct 15, 2024
Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
(cherry picked from commit 7b0a573)

# Conflicts:
#	accounts-db/src/accounts.rs
#	core/src/banking_stage/consumer.rs
#	core/src/banking_stage/immutable_deserialized_packet.rs
#	core/src/banking_stage/latest_unprocessed_votes.rs
#	core/src/banking_stage/transaction_scheduler/scheduler_controller.rs
#	runtime/src/bank/address_lookup_table.rs
apfitzge added a commit that referenced this pull request Oct 17, 2024
* Scheduler: Improve TTL (#3161)

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
(cherry picked from commit 7b0a573)

# Conflicts:
#	accounts-db/src/accounts.rs
#	core/src/banking_stage/consumer.rs
#	core/src/banking_stage/immutable_deserialized_packet.rs
#	core/src/banking_stage/latest_unprocessed_votes.rs
#	core/src/banking_stage/transaction_scheduler/scheduler_controller.rs
#	runtime/src/bank/address_lookup_table.rs

* resolve conflicts

---------

Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.0 Backport to v2.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants