CI: Add windows clippy job and fix clippy errors #330
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 837 837
Lines 226896 226896
=========================================
- Hits 185901 185883 -18
- Misses 40995 41013 +18 |
There was a problem hiding this comment.
thank you for creating this one! 🫶 iirc I got stuck by libloading things in the geyser plugin but can't remember the reason.
about the mac clippy, I guess you hit cache 🤔 there is a random build from solana repo: https://github.com/solana-labs/solana/actions/runs/7421447588. both of them can take ~2x mins. in the beginning, I only updated nightly one due to the flaky results, then I found we still had budget so I did stable one as well for the symmetry 🙈 tbh, I'm okay to switch them back if we have the consensus!
|
btw, I try to have this one for saving some budget: #244 |
|
Ah cool, thanks for providing the info! I'll take a look at the other PR |
* CI: Run clippy on windows * Update cargo-clippy-before-script.sh for Windows * Pacify clippy
Problem
#234 broke the Windows build, but we weren't able to detect it with CI until the windows build was started aftewards.
Summary of Changes
Add a step to the clippy CI to run clippy on a Windows machine. Here's a successful CI run: https://github.com/joncinque/solana/actions/runs/8348778898/job/22853151448
While testing this, I tried downgrading the mac machine from
macos-latest-largetomacos-latest, and the job is still pretty fast, taking 16m30s compared to 13m30s. And I don't think we would use minutes if we downgrade that machine.Anyway, let me know what you think!