Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing description for solana-lattice-hash #3358

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

yihau
Copy link
Member

@yihau yihau commented Oct 29, 2024

Problem

need the description for publishing crate

Summary of Changes

add a basic one

@yihau yihau added the v2.1 Backport to v2.1 branch label Oct 29, 2024
@yihau yihau requested a review from brooksprumo October 29, 2024 15:56
Copy link

mergify bot commented Oct 29, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@brooksprumo
Copy link

Why do we need to publish this crate?

@yihau
Copy link
Member Author

yihau commented Oct 29, 2024

we don't assign publish = false in #2204 so I assume we wanna publish it 🤔
even if we don’t publish the crate, we will face another issue because we publish solana-accounts-db, and this crate is one of its dependencies. iirc, we usually publish deps as well

@yihau yihau merged commit 51a114e into anza-xyz:master Oct 29, 2024
37 checks passed
@yihau yihau deleted the missing-description branch October 29, 2024 17:51
mergify bot pushed a commit that referenced this pull request Oct 29, 2024
yihau added a commit that referenced this pull request Oct 30, 2024
) (#3363)

add missing description for solana-lattice-hash (#3358)

(cherry picked from commit 51a114e)

Co-authored-by: Yihau Chen <yihau.chen@icloud.com>
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.1 Backport to v2.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants