Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1: Revert "remove test-only bool arg from calculate_fee (#3211)" (backport of #3367) #3373

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 29, 2024

This reverts commit aad0381.

Problem

  • Testnet has a 0 target_lamports_per_signature in its genesis config which was triggering this case intended to be for only local-cluster/tests.

Summary of Changes

  • Revert the commit

Fixes #


This is an automatic backport of pull request #3367 done by [Mergify](https://mergify.com).

Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this BP in 2.1 - without it; 2.1 branch won't charge base fee and immediately diverge from v1.18/v2.0

Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge merged commit 285e2e8 into v2.1 Oct 30, 2024
40 checks passed
@apfitzge apfitzge deleted the mergify/bp/v2.1/pr-3367 branch October 30, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants