Disallow --rocksdb-shred-compaction fifo in the validator #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of fifo compaction in rocksdb is deprecated (as of v2.0). The current behavior emits a warning if fifo is set. This change removes "fifo" as an option, leaving "level" as the only valid value for --rocksdb-shred-compaction
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
AshwinSekar
previously approved these changes
Nov 4, 2024
AshwinSekar
approved these changes
Nov 4, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
The use of fifo compaction in rocksdb is deprecated (as of v2.0). The current behavior emits a warning if fifo is set. This change removes "fifo" as an option, leaving "level" as the only valid value for --rocksdb-shred-compaction (cherry picked from commit fddc554)
steviez
added a commit
that referenced
this pull request
Nov 5, 2024
…port of #3451) (#3464) Disallow --rocksdb-shred-compaction fifo in the validator (#3451) The use of fifo compaction in rocksdb is deprecated (as of v2.0). The current behavior emits a warning if fifo is set. This change removes "fifo" as an option, leaving "level" as the only valid value for --rocksdb-shred-compaction (cherry picked from commit fddc554) Co-authored-by: steviez <steven@anza.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fifo compaction in rocksdb (Blockstore) was deprecated in v2.0 (see #1882). Currently, a warning is emitted but use of
fifois still permitted.Summary of Changes
This change actually makes
fifoan invalid option for--rocksdb-shred-compaction, leavinglevelas the only valid option.The actual fifo code that is plumbed down several layers will be removed in a subsequent PR
Testing
Started a validator real quick and ensured that things errored out with
--rocksdb-shred-compaction fifoand that--rocksdb-shred-compaction levelOR not specifying that flag at all proceeded without issue