remove ntapi patch #3584
remove ntapi patch #3584
Conversation
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
|
found solana-labs#32488 and solana-labs#32491. do we still need to patch this one 🤔 |
as you guessed, this entirely should rather be removed. it's no longer used as indicated here:
|
| --config 'patch.crates-io.ntapi.git="https://github.com/solana-labs/ntapi"' \ | ||
| --config 'patch.crates-io.ntapi.rev="97ede981a1777883ff86d142b75024b023f04fad"' \ | ||
| install --locked spl-token-cli --root "$installDir" $maybeSplTokenCliVersionArg | ||
| "$cargo" $maybeRustVersion install --locked spl-token-cli --root "$installDir" $maybeSplTokenCliVersionArg |
There was a problem hiding this comment.
nit: seems the needed shellcheck disable=... is missing...
* use anza-xyz/ntapi instead of the labs one * remove ntapi patch * fix shellcheck (cherry picked from commit da90cbe)
* use anza-xyz/ntapi instead of the labs one * remove ntapi patch * fix shellcheck (cherry picked from commit da90cbe)
Problem
we should use anza-xyz/ntapi as the vendor. just forked it and the commit, https://github.com/anza-xyz/ntapi/commits/97ede981a1777883ff86d142b75024b023f04fad, is reachableremove outdated patch