v2.1: Add not unique leader discovery (backport of #3546) #3658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* rename get_leader_sockets to get_unique_leader_sockets * Add methods for getting not unique tpu sockets (cherry picked from commit dffcdb4)
|
The naming of these methods is all wrong, but hear me out: the PR renames an existing method - @KirillLykov it'd be great if in a follow up PR you could add example results of the two methods, and rename _sockets to _socket_addrs or something - I thought we were creating sockets and almost had an aneurysm. |
alessandrod
approved these changes
Nov 16, 2024
t-nelson
reviewed
Nov 18, 2024
t-nelson
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, TpuClient next API allows to get only unique future leaders. For example, if the leader schedule is
[L1, L1, L1, L1, L2, L2, L2, L2, L1, L1, L1, L1], it will return[L1, L2]. While for the internal logic oftpu-client-nextit is desirable to get[L1, L2, L1]instead.Summary of Changes
This is an automatic backport of pull request #3546 done by [Mergify](https://mergify.com).