Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1: Ensure that Rc in AccountInfo is not stored in an account (backport of #3471) #3723

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 20, 2024

Problem

With direct mapping, AccountInfo should not be allowed to be stored in accounts; that includes the Rc<T> as well.

Summary of Changes

Fixes #


This is an automatic backport of pull request #3471 done by [Mergify](https://mergify.com).

* Ensure that Rc in AccountInfo is not stored in an account

(cherry picked from commit 030a558)
@mergify mergify bot requested a review from a team as a code owner November 20, 2024 16:22
Copy link
Author

mergify bot commented Nov 20, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@seanyoung
Copy link

This is some work that was missed in #3044
We need to ensure that AccountInfo fields are not in the input area.
Needed for direct mapping.

Cc @alessandrod

Copy link

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the direct mapping feature gate will be rekeyed as a result of this change to its logic, right?

this must be done before the next 2.1 release after the backport is merged

@seanyoung seanyoung merged commit 32b445a into v2.1 Dec 4, 2024
28 checks passed
@seanyoung seanyoung deleted the mergify/bp/v2.1/pr-3471 branch December 4, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants