-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs with Anza logo #3851
Conversation
Hey @yihau, is there any reason we can't publish PRs that modify docs on vercel? If we used a different project name each time (eg |
I assume you're referring to the PRs' deployment preview, I guess we just not use it. imo, we can enable this feature.
I think we can enable the vercel feature directly like https://www.github.com/solana-labs/explorer/pull/416 instead of creating many different new projects 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also consider this PR for BP so that the published docs at https://docs.anza.xyz/
get the update soon vs. when we cut new branches such that this commit is in beta
branch
If I recall correctly, going to beta
(2.1) should be sufficient, but someone should double check me there 😄
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
(cherry picked from commit dbbe367)
(cherry picked from commit dbbe367)
Yeah good call
beta gets published to https://docs.anza.xyz/ and https://beta.docs.anza.xyz/. Stable branch gets published to https://stable.docs.anza.xyz/. I'm opening BPs for both branches to keep all domains the same. We'll see if the BP Reviewers agree :-) |
Ha, I'm obviously in favor of it so feel free to tag me in those BP reviews once CI is passing |
(cherry picked from commit dbbe367)
Problem
Agave docs (docs.anza.xyz) still have Solana Labs branding (#3824)
Summary of Changes
Note: There are several other files that contain old logos in docs/static/img:
It's not clear to me if any of these are actually used. They're not referenced anywhere in the repo, but maybe Docusaurus uses them somehow. After this PR is merged and published to edge.docs.anza.xyz I'll see if they show up anywhere on the site. After that I will either update them or delete them in another PR.
Fixes: #3824