use trailing_zeros for threadset iteration #3871
Conversation
| None | ||
| } else { | ||
| let thread_id = self.0.trailing_zeros() as ThreadId; | ||
| self.0 &= self.0 - 1; |
There was a problem hiding this comment.
I had to stare at this for longer than I'd care to admit, but looks good 👍
There was a problem hiding this comment.
I had to stare at this for longer than I'd care to admit, but looks good 👍
this is usually sufficient to justify a code comment for the sake of future maintainers
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
(cherry picked from commit ec8ba13)
Problem
select_threadshowing up in profiles, think it is likely due to thisSummary of Changes
trailing_zerosand modify value to iterator thread-setsFixes #