[message] Do not include secp256r1 signature from the total number of signature counts #4382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
approved these changes
Jan 10, 2025
|
reverts just the breaking chance instead of entire PR. seems fine to me - @jstarry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The secp256r1 precompile signatures were added and included (#3878) to the total signature count in
TransactionSignatureDetails. Although the secp256r1 precompile is behind a feature gate, this could potentially result in different fees for different versions.Summary of Changes
Exclude the secp256r1 signatures from the total signature count.
Fixes #