Apply more unified scheduler related core cleanups #4453
+40
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Jan 14, 2025
Comment on lines
+62
to
+66
| #[cfg_attr( | ||
| feature = "frozen-abi", | ||
| derive(AbiExample), | ||
| frozen_abi(digest = "DAdZnX6ijBWaxKAyksq4nJa6PAZqT4RShZqLWTtNvyAM") | ||
| )] |
There was a problem hiding this comment.
this was temporarily removed by #3974. but it seems the reported build issue disappeared..
ryoqun
commented
Jan 14, 2025
| @@ -106,7 +106,6 @@ tokio = { workspace = true, features = ["full"] } | |||
| trees = { workspace = true } | |||
|
|
|||
| [dev-dependencies] | |||
| assert_matches = { workspace = true } | |||
There was a problem hiding this comment.
should have been removed at the same timing with #4123...
ryoqun
changed the title
apfitzge
reviewed
Jan 14, 2025
Comment on lines
+764
to
+767
| // Create a partially-dummy ClusterInfo for the banking stage. | ||
| let cluster_info_for_banking = Arc::new(DummyClusterInfo { | ||
| id: simulated_leader.into(), | ||
| }); |
There was a problem hiding this comment.
iirc cluster info is only needed for forwarding. once I remove forwarding from banking stage (soon after #3820) we can get rid of all this I think.
apfitzge
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
more clean up is needed after #4123
Summary of Changes
Do it.
extracted from #3946