turbine: Adjust reference tick calculation #4644
Open
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current reference tick calculation results in the reference tick being recorded as 0 when a Bank has reached max tick height. This could lead a node to incorrectly believe they are late in receiving this shread which could lead to a premature repair request being sent. So, adjust the calculation to sature at bank.ticks_per_slot() - 1
steviez
changed the title
bw-solana
approved these changes
Jan 27, 2025
| @@ -268,7 +268,11 @@ impl StandardBroadcastRun { | |||
|
|
|||
| // 2) Convert entries to shreds and coding shreds | |||
| let is_last_in_slot = last_tick_height == bank.max_tick_height(); | |||
| let reference_tick = bank.tick_height() % bank.ticks_per_slot(); | |||
| let reference_tick = if is_last_in_slot { | |||
| bank.ticks_per_slot() - 1 | |||
behzadnouri
reviewed
Jan 27, 2025
| @@ -268,7 +268,11 @@ impl StandardBroadcastRun { | |||
|
|
|||
| // 2) Convert entries to shreds and coding shreds | |||
| let is_last_in_slot = last_tick_height == bank.max_tick_height(); | |||
| let reference_tick = bank.tick_height() % bank.ticks_per_slot(); | |||
There was a problem hiding this comment.
If we are changing this I would rather to change it to:
let reference_tick = last_tick_height
.saturating_add(bank.ticks_per_slot())
.saturating_sub(bank.max_tick_height());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current reference tick calculation results in the reference tick being recorded as 0 when a Bank has reached max tick height
Summary of Changes
Adjust the calculation to saturate at
bank.ticks_per_slot() - 1, which coincides with the max value of 63 that fit in the 6 bits allocated forreference_tickin the shred header