-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vote: deprecate legacy vote instructions #587
vote: deprecate legacy vote instructions #587
Conversation
Needs SIMD. Can fast track. Languages is very simple: After feature gate, these instructions (list them) will no longer be supported. |
d60731e
to
efcaa74
Compare
efcaa74
to
e896af6
Compare
The Firedancer team maintains a line-for-line reimplementation of the |
e896af6
to
094b4d1
Compare
If this PR represents a change to the public RPC API:
Thank you for keeping the RPC clients in sync with the server API @AshwinSekar. |
27d6ed0
to
7c57046
Compare
bc426aa
to
aae8cce
Compare
aae8cce
to
01c2a93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will impl on our side after bp
* vote: deprecate legacy vote instructions * fix tests
Problem
Validator no longer sends the legacy vote instructions. It is cumbersome to keep these old vote instructions around and ensure parity.
Summary of Changes
Gate behind a new flag and the activation flag of the latest vote ix (TowerSync #365).
Once both of these are activated, legacy vote ixs will no longer be processed by the vote program.
For reviewers:
1st commit is the actual logic, second commit updates the tests.
Part of the #2597 effort