Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: deprecate legacy vote instructions #587

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

AshwinSekar
Copy link

@AshwinSekar AshwinSekar commented Apr 4, 2024

Problem

Validator no longer sends the legacy vote instructions. It is cumbersome to keep these old vote instructions around and ensure parity.

Summary of Changes

Gate behind a new flag and the activation flag of the latest vote ix (TowerSync #365).
Once both of these are activated, legacy vote ixs will no longer be processed by the vote program.

For reviewers:

1st commit is the actual logic, second commit updates the tests.

Part of the #2597 effort

@AshwinSekar AshwinSekar requested a review from carllin April 4, 2024 22:34
carllin
carllin previously approved these changes Apr 6, 2024
@lheeger-jump
Copy link

lheeger-jump commented Apr 9, 2024

Needs SIMD. Can fast track.

Languages is very simple:

After feature gate, these instructions (list them) will no longer be supported.

@AshwinSekar
Copy link
Author

@AshwinSekar AshwinSekar force-pushed the deprecate-legacy-vote branch 2 times, most recently from d60731e to efcaa74 Compare April 16, 2024 03:53
@AshwinSekar AshwinSekar added the feature-gate Pull Request adds or modifies a runtime feature gate label Apr 22, 2024
@AshwinSekar AshwinSekar force-pushed the deprecate-legacy-vote branch from efcaa74 to e896af6 Compare August 14, 2024 17:16
@AshwinSekar AshwinSekar marked this pull request as draft August 14, 2024 17:16
Copy link

mergify bot commented Aug 14, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@AshwinSekar AshwinSekar force-pushed the deprecate-legacy-vote branch from e896af6 to 094b4d1 Compare August 14, 2024 20:13
Copy link

mergify bot commented Aug 14, 2024

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @AshwinSekar.

@AshwinSekar AshwinSekar force-pushed the deprecate-legacy-vote branch 4 times, most recently from 27d6ed0 to 7c57046 Compare August 14, 2024 20:55
@AshwinSekar AshwinSekar force-pushed the deprecate-legacy-vote branch 2 times, most recently from bc426aa to aae8cce Compare August 14, 2024 21:10
@AshwinSekar AshwinSekar force-pushed the deprecate-legacy-vote branch from aae8cce to 01c2a93 Compare August 14, 2024 21:12
@AshwinSekar AshwinSekar marked this pull request as ready for review August 15, 2024 14:06
Copy link

@lidatong lidatong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will impl on our side after bp

@AshwinSekar AshwinSekar merged commit 993d223 into anza-xyz:master Aug 15, 2024
51 checks passed
@AshwinSekar AshwinSekar deleted the deprecate-legacy-vote branch August 15, 2024 18:25
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
* vote: deprecate legacy vote instructions

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants