Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize max streams per ms #707

Merged

Conversation

lijunwangs
Copy link

@lijunwangs lijunwangs commented Apr 10, 2024

Problem

The upper layer like jato-relayer may want different PPS for tpu and tpu_forward than the default value. Our validator may use different values for tpu vs forward. This changes makes it possible.

Summary of Changes

Make it parameter instead of the hard coded

Fixes #

core/src/tpu.rs Outdated Show resolved Hide resolved
core/src/tpu.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.9%. Comparing base (baed522) to head (bdf8a48).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #707   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         851      851           
  Lines      231100   231137   +37     
=======================================
+ Hits       189395   189465   +70     
+ Misses      41705    41672   -33     

@lijunwangs lijunwangs force-pushed the parameterize_max_streams_per_ms branch from 82edd41 to bdf8a48 Compare April 11, 2024 19:45
core/src/tpu.rs Outdated Show resolved Hide resolved
Copy link

mergify bot commented Apr 15, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@lijunwangs lijunwangs merged commit f2aa4f0 into anza-xyz:master Apr 15, 2024
48 checks passed
mergify bot pushed a commit that referenced this pull request Apr 15, 2024
Make PPS a parameter instead of the hard coded

(cherry picked from commit f2aa4f0)

# Conflicts:
#	quic-client/tests/quic_client.rs
lijunwangs pushed a commit that referenced this pull request Apr 19, 2024
Make PPS a parameter instead of the hard coded
michaelschem pushed a commit to michaelschem/agave that referenced this pull request Apr 20, 2024
Make PPS a parameter instead of the hard coded
Copy link

mergify bot commented Apr 29, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

mergify bot pushed a commit that referenced this pull request Apr 29, 2024
Make PPS a parameter instead of the hard coded

(cherry picked from commit f2aa4f0)

# Conflicts:
#	client/src/connection_cache.rs
#	core/src/tpu.rs
#	quic-client/tests/quic_client.rs
#	streamer/src/nonblocking/quic.rs
#	streamer/src/nonblocking/stream_throttle.rs
lijunwangs added a commit that referenced this pull request Apr 29, 2024
Make PPS a parameter instead of the hard coded

(cherry picked from commit f2aa4f0)

# Conflicts:
#	client/src/connection_cache.rs
#	core/src/tpu.rs
#	quic-client/tests/quic_client.rs
#	streamer/src/nonblocking/quic.rs
#	streamer/src/nonblocking/stream_throttle.rs
lijunwangs added a commit that referenced this pull request Apr 30, 2024
* Parameterize max streams per ms (#707)

Make PPS a parameter instead of the hard coded


Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com>
anwayde pushed a commit to firedancer-io/agave that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants