createRecentSignatureConfirmationPromiseFactory now properly throws error #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: effef2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
steveluscher
approved these changes
Nov 3, 2025
Collaborator
steveluscher
left a comment
steveluscher
left a comment
There was a problem hiding this comment.
Oh wow, that's embarrassing. Thanks for catching that!
Contributor
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Solana Kit Docs' |
Contributor
Author
|
no worries, it happens, hard to catch. thanks for quick reaction @steveluscher |
This was referenced Nov 3, 2025
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The issue reported here has been somewhat fixed here
However, cause of
signatureStatus?.errcheck being down the line in the code it may result with getting no error output even though there is one.If you were to apply the tests added in this PR, they should fail with current
maincode.Summary of Changes
Moves error check before all other if/else which makes sure error is thrown in all cases.