-
Notifications
You must be signed in to change notification settings - Fork 124
Node 25.2.0 needs you to specify a place to store localstorage #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 25.2.0 needs you to specify a place to store localstorage #1019
Conversation
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
BundleMonUnchanged files (130)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
2e1334d to
3056249
Compare
|
Documentation Preview: https://kit-docs-8yozypw3p-anza-tech.vercel.app |
3056249 to
0eb64fd
Compare
mcintyre94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Is it not possible to add these node options to |
|
I don't think so, because Jest doesn't invoke Node, Node invokes Jest. That would be nice though if anyone knows a way. |
0eb64fd to
3d19e5d
Compare
| "scripts": { | ||
| "build": "NODE_OPTIONS='--max-old-space-size=8192' next build", | ||
| "dev": "next dev --turbo", | ||
| "dev": "NODE_OPTIONS=\"--localstorage-file=/tmp/node-localstorage-$(head /dev/urandom | tr -dc a-zA-Z0-9 | head -c 8)\" next dev --turbo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to add this to the dev mode of the docs site too.
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Solana Kit Docs' |

Problem
Node 25.2.0 dies if you don't tell it where to stuff localstorage data.
See jestjs/jest#15888 and nodejs/node#60704.
Summary of Changes
Every time you run tests, specify a random temp file.