CI with v2.2 of Agave #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
BundleMonFiles updated (3)
Unchanged files (124)
Total files change +107B +0.03% Final result: ✅ View report in BundleMon website ➡️ |
Merged
Contributor
|
Documentation Preview: https://kit-docs-jsxe0qalr-anza-tech.vercel.app |
steveluscher
force-pushed
the
06-17-ci_with_v2.2_of_agave
branch
3 times, most recently
from
49a1b69 to
d783175
Compare
steveluscher
force-pushed
the
06-17-ci_with_v2.2_of_agave
branch
from
d783175 to
942fb2c
Compare
steveluscher
commented
Jun 20, 2025
Comment on lines
+218
to
+223
| """ | ||
| Token-2022 Extension: Unparseable | ||
| """ | ||
| type SplTokenExtensionUnparseable implements SplTokenExtension { | ||
| extension: String | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
@buffalojoec, I snuck this in here, because the current test fixtures actually produce an unparseable extension as of Agave 2.2.
|
|
||
| it('produces vote notifications', async () => { | ||
| expect.assertions(1); | ||
| // FIXME: Re-enable once https://github.com/anza-xyz/agave/pull/6645 is live. |
Collaborator
Author
There was a problem hiding this comment.
| set -e | ||
| version=$(node -e \ | ||
| 'fetch("https://api.github.com/repos/anza-xyz/agave/releases").then(res => res.json().then(rs => rs.filter(r => !r.prerelease && r.tag_name.startsWith("v2.0."))).then(x => console.log(x[0].tag_name)));' | ||
| 'fetch("https://api.github.com/repos/anza-xyz/agave/releases").then(res => res.json().then(rs => rs.filter(r => !r.prerelease && r.tag_name.startsWith("v2.2."))).then(x => console.log(x[0].tag_name)));' |
Collaborator
Author
There was a problem hiding this comment.
This is the change.
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
2.0 is really old, and CI is starting to fall behind.
Summary of Changes
Install 2.2.x when running CI.