fix: fromVersionedTransaction bug #906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b84a18b The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
guibescos
changed the title
BundleMonUnchanged files (130)
Total files change -6B 0% Final result: ✅ View report in BundleMon website ➡️ |
steveluscher
added
the
automerge
Contributor
|
Automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
This was referenced Sep 25, 2025
Merged
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fromVersionedTransactioncurrently fails forVersionedTransactionthat use address lookup tables.The reason for this is
fromVersionedTransactiontries to resolve all the accounts for the inputVersionedTransaction, but doesn't have access to the lookup tables involved in the transaction. However if we look further in the function we notice we are only interested in the static accounts, which is where the signers are.Summary of Changes
Use
message.staticAccountKeysinstead ofmessage.getAccountKeys()which tries to resolve all the accounts.