[SOL] Expand memcmp earlier #170
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It has been pointed out that comparing pub keys with the equal operator consumes more CUs than it should. I found the problem to be that LLVM lowers memcmp too late in the pipeline stage, so that it still contains suboptimal code when going to machine code generation.
Solution
Lower memcmp earlier.
Benchamarks
Programs/sbf
No change to solana or Pinocchio entrypoint
Pubkey comparison
P-token (after reverting solana-program/token#90 and removing pubkey_eq from Pinocchio).
The comparison is against LLVM master with p-token unmodified and this PR with the p-token without pubkey_eq.