[SOL] Remove Intrinsic::bpf_compare
#95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmakarov
approved these changes
Apr 8, 2024
LucasSte
merged commit 1dd7575
into
anza-xyz:solana-rustc/17.0-2023-12-14
14 checks passed
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Jun 28, 2024
LucasSte
added a commit
that referenced
this pull request
Aug 19, 2024
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The SBF target is still dependent on the BPF intrinsics. We depend on intrinsics unsupported in the SBF target or on intrinsics that are not necessary for our code generation.
Intrinsic::bpf_compareexists to disable an LLVM optimization that might break the kernel BPF verifier. The SBF verifier does not contain the verification rule mentioned in the comment, so the optimization that the intrinsic disables can be turned back on.If we wish to upstream the SBF target at some point, decreasing the dependency on BPF is beneficial.
Solution
I removed the IR adjustment that inserted the intrinsic and later removed it. This enables the optimization that converts
(conv)a < power_2_consttoa & <const>.