Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AccountMeta.pubkey public #10

Closed
wants to merge 1 commit into from
Closed

Make AccountMeta.pubkey public #10

wants to merge 1 commit into from

Conversation

billythedummy
Copy link
Contributor

As a lib consumer, there was no way to construct an AccountMeta struct previously because there were no constructor functions and AccountMeta.pubkey was private

@febo
Copy link
Collaborator

febo commented Sep 6, 2024

See #11 – maybe we can improve the whole type and then this gets fixed as well.

@febo
Copy link
Collaborator

febo commented Sep 13, 2024

Closing this as #11 already incorporate changes to the AccountMeta type. In general, we should avoid exposing raw pointer fields since they do not have an explicit associated lifetime.

@febo febo closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billythedummy @febo