Supporting versioned transactions in WalletConnect

[jnwng]

depends on a full release of @jnwng/walletconnect-solana

by spec, WalletConnect v2 does not technically fully support versioned transactions.

however, since we can cast legacy transactions as deprecated Transactions, we can fulfill the spec and relay legacy transactions.

v0 transactions are not officially supported in that specification, but the addition of a serialized transaction parameter in WalletConnect/walletconnect-solana-adapter#9 means we can support v0 (and theoretically any future version) by serializing the transaction as a parameter, and allowing wallets to handle whether they support that particular version. this is much more flexible than the current format that requires hydration of all information prior to transmission to the network

[changeset-bot]

🦋 Changeset detected

Latest commit: 8ededf0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@solana/wallet-adapter-walletconnect	Patch
@solana/wallet-adapter-wallets	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

[jnwng]

bumping this package because of the addition of the supportedTransactionVersions + the version bump in @jnwng/walletconnect-solana

[jordaaash]

This might be neither here nor there, but it feels like the WC2 spec for solana_signTransaction is unnecessarily brittle here. Why does it represent transactions with JSON fields instead of just encoded bytes? Serialization of the transaction shouldn't be a concern for the transmission layer, as it's just wiring it to a wallet, and this particular serialization format has no meaning outside of convention in web3.js.

[jordaaash]

Just a few small things, looks like some of the changes are just related to testing.

[jordaaash]

Looks good!

[lexer]

Let's go! :)

[socket-security]

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages		Version	New capabilities	Transitives1	Size	Publisher
@walletconnect/types	🆕	2.7.7	None	+2	572 kB	gancho_walletconnect
@jnwng/walletconnect-solana	⬆️	0.1.5...0.2.0	None	+3/-10	507 kB	jnwng

🚮 Removed packages: turbo@1.8.8

Footnotes

1. https://docs.socket.dev ↩