Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @trezor/connect-web to version 9.2.1 #920

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

gabrielKerekes
Copy link
Contributor

@gabrielKerekes gabrielKerekes commented Mar 5, 2024

Temporarily fix #918.

Trezor have already created a PR with a fix for the issue - trezor/trezor-suite#11443. I asked how soon they'd release, but haven't gotten a response yet. If it should be today/tomorrow then it's perhaps not worth it to merge this. I'll let you know as soon as I get a response.

Bump @trezor/connect-web web version to 9.2.1 so that users don't accidentally install version 9.2.0 which would resulted in a broken build of their app.

@gabrielKerekes
Copy link
Contributor Author

Trezor should release the fix today or tomorrow - trezor/trezor-suite#11443 (comment).

@mcintyre94 mcintyre94 self-requested a review March 5, 2024 09:54
@mcintyre94
Copy link
Collaborator

mcintyre94 commented Mar 7, 2024

@gabrielKerekes Would you mind bumping this to ^9.2.1 just to make sure nobody picks up a broken version going forward? I'm unsure which dependencies are good/bad between >9.1.6 and <9.2.1, but let's just make sure nobody gets any of them going forward.

@gabrielKerekes gabrielKerekes force-pushed the fix-trezor-broken-build branch from 4eca9f0 to a73d5bc Compare March 7, 2024 12:37
@gabrielKerekes gabrielKerekes changed the title fix: pin @trezor/connect-web version to 9.1.6 chore: bump @trezor/connect-web to version 9.2.1 Mar 7, 2024
@gabrielKerekes
Copy link
Contributor Author

I force-pushed the update to 9.2.1. a73d5bc. I also renamed the PR and updated the description for future reference.

Just FYI - it was only version 9.2.0 which was broken.

@mcintyre94 mcintyre94 merged commit 888a854 into anza-xyz:master Mar 7, 2024
1 check passed
@mcintyre94
Copy link
Collaborator

Perfect, thankyou!

mcintyre94 added a commit that referenced this pull request Mar 7, 2024
jordaaash pushed a commit that referenced this pull request Mar 7, 2024
* Revert "Bump `@trezor/connect-web` to `9.2.1` (#920)"

This reverts commit 888a854.

* chore: bump @trezor/connect-web to version 9.2.1

Co-authored-by: Gabriel Kerekeš <gabrielKerekes@users.noreply.github.com>

---------

Co-authored-by: Gabriel Kerekeš <gabrielKerekes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trezor wallet dependency issue causing error in wallet-adapter-wallets
2 participants