Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping the minor version for the walletconnect package #942

Closed
wants to merge 3 commits into from

Conversation

jnwng
Copy link
Contributor

@jnwng jnwng commented Apr 5, 2024

i missed this when @jnwng/walletconnect-solana@0.3.0 got released

@jnwng jnwng changed the title Bumping the minor version Bumping the minor version for the walletconnect package Apr 5, 2024
@Fatih-Hocur
Copy link

Hi,
do you have any updates on the status of this PR? When can we expect it to be merged?
Thanks!

@deadeagle63
Copy link

@jnwng do we have an ETA on this potentially going in? :D

@usgoose
Copy link

usgoose commented Jun 5, 2024

Would be helpful to get this in for some Solana protocols facing issues 🙏 @jnwng

jnwng and others added 2 commits June 12, 2024 14:48
i missed this when `@jnwng/walletconnect-solana@0.3.0` got released
@jordaaash
Copy link
Collaborator

Build failing:

@solana/wallet-adapter-walletconnect:build: ../../../node_modules/.pnpm/@walletconnect+core@2.13.2_@react-native-async-storage+async-storage@1.19.1_bufferutil@4.0.7_utf-8-validate@5.0.10/node_modules/@walletconnect/core/dist/types/controllers/relayer.d.ts:13:5 - error TS2416: Property 'provider' in type 'Relayer' is not assignable to the same property in base type 'IRelayer'.
@solana/wallet-adapter-walletconnect:build:   Type 'import("/Users/jordan/Github/anza-xyz/wallet-adapter/node_modules/.pnpm/@walletconnect+jsonrpc-types@1.0.3/node_modules/@walletconnect/jsonrpc-types/dist/cjs/provider").IJsonRpcProvider' is not assignable to type 'import("/Users/jordan/Github/anza-xyz/wallet-adapter/node_modules/.pnpm/@walletconnect+jsonrpc-types@1.0.4/node_modules/@walletconnect/jsonrpc-types/dist/types/provider").IJsonRpcProvider'.
@solana/wallet-adapter-walletconnect:build:     Property 'setConnection' is protected but type 'IJsonRpcProvider' is not a class derived from 'IJsonRpcProvider'.
@solana/wallet-adapter-walletconnect:build:
@solana/wallet-adapter-walletconnect:build: 13     provider: IJsonRpcProvider;
@solana/wallet-adapter-walletconnect:build:        ~~~~~~~~
@solana/wallet-adapter-walletconnect:build:
@solana/wallet-adapter-walletconnect:build:
@solana/wallet-adapter-walletconnect:build: Found 2 errors.
@solana/wallet-adapter-walletconnect:build:
@solana/wallet-adapter-walletconnect:build:  ELIFECYCLE  Command failed with exit code 1.
@solana/wallet-adapter-walletconnect:build: ERROR: command finished with error: command (/Users/jordan/Github/anza-xyz/wallet-adapter/packages/wallets/walletconnect) /Users/jordan/Github/anza-xyz/wallet-adapter/node_modules/.bin/pnpm run build exited (1)
@solana/wallet-adapter-walletconnect#build: command (/Users/jordan/Github/anza-xyz/wallet-adapter/packages/wallets/walletconnect) /Users/jordan/Github/anza-xyz/wallet-adapter/node_modules/.bin/pnpm run build exited (1)

@glitch-txs
Copy link
Contributor

Hello, we've fork jnwng's repo and soon release the adapter as a standalone library, we will also soon open a PR to update it here.

I'd appretiate everyone's feedback: https://github.com/WalletConnect/walletconnect-solana

This can be closed for now 👍

@jordaaash jordaaash closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants