Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsular connectionId dentro de Network #401

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

matisandacz
Copy link
Contributor

@matisandacz matisandacz commented Apr 21, 2022

#400
La clase ServerRequestProcessor es la encargada de procesar todos los IRequests que provienen del cliente.

En este PR, refactorizamos esta clase para que el connectionId del jugador no salga fuera de la misma. Así, evitamos tener dos formas redundantes de identificar a un jugador y reducimos posibles confusiones.

@matisandacz matisandacz changed the title Encapsular connectionId dentro del Network Encapsular connectionId dentro de Network Apr 21, 2022
@matisandacz matisandacz self-assigned this Apr 21, 2022
@matisandacz matisandacz added the refactor Code refactoring. Major changes. label Apr 21, 2022
@matisandacz matisandacz linked an issue Apr 21, 2022 that may be closed by this pull request
@cpbeto
Copy link
Contributor

cpbeto commented Apr 21, 2022

Genial, gracias. 💯

@cpbeto cpbeto merged commit df2c38d into ao-libre:desarrollo-v0.1.15 Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactoring. Major changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encapsular connectionId dentro del Network
2 participants