Skip to content
This repository has been archived by the owner on Feb 13, 2021. It is now read-only.

Commit

Permalink
Merge pull request #19 in AOLP_ADS_JS/prebid.js from release/1.0.5 to…
Browse files Browse the repository at this point in the history
… master

* commit '863d8bd34646511969a199e35f6f1cd64eacd2fe':
  Set the PMP deal ID on the bid object, if available.
  • Loading branch information
Samuel Adu committed Aug 30, 2016
2 parents 90d8ed2 + 863d8bd commit 08d50c0
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 2 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
AOL Prebid 1.0.5
----------------
BUGFIX: Ensure that an event is logged in the case when there are no bids from the DSPs.
Populate the bid object with the deal ID for private deals.


AOL Prebid 1.0.4
----------------
BUGFIX: Fixed default server for AOL adapter & analytics.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "aol-container-tag",
"version": "1.0.4",
"version": "1.0.5",
"description": "AOL Header Bidding Container Tag Library",
"main": "src/prebid.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion src/adapters/analytics/aol.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export default utils.extend(adapter({
for (let code in adUnits) {
if (adUnits.hasOwnProperty(code)) {
let adUnit = adUnits[code];
if (adUnit.aolParams && adUnit.winner.cpm) {
if (adUnit.aolParams) {
let url = this.buildEndpoint(EVENTS.AUCTION, adUnit);
this.reportEvent(url);
}
Expand Down
3 changes: 3 additions & 0 deletions src/adapters/aol.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ var AolAdapter = function AolAdapter() {
bidResponse.height = response.getAdHeight();
bidResponse.creativeId = response.getCreativeId();
bidResponse.pubapiId = response.getId();
try {
bidResponse.dealId = response.data.seatbid[0].bid[0].dealid;
} catch(e) {}

// add it to the bid manager
bidmanager.addBidResponse(bid.placementCode, bidResponse);
Expand Down

0 comments on commit 08d50c0

Please sign in to comment.