Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows duplicate keys #151

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Windows duplicate keys #151

merged 3 commits into from
Mar 2, 2023

Conversation

ViniciusAndr
Copy link
Contributor

@ViniciusAndr ViniciusAndr commented Mar 2, 2023

Resolves #136

Hi, I saw that the error happened because the code was called twice, I couldn't figure out the reason, but this change worked for me.

I put a timer to give a delay of 0.3 seconds for each command only when it is windows and that solved the error, as I have no experience in rust so I don't know if there would be another way to solve it

@aome510
Copy link
Owner

aome510 commented Mar 2, 2023

Hi, I saw that the error happened because the code was called twice, I couldn't figure out the reason, but this change worked for me.

Hi, thanks for raising this. I actually did a quick search on https://github.com/crossterm-rs/crossterm and found crossterm-rs/crossterm#752. I kinda know how to fix this issue rn, will update in this PR.

@aome510
Copy link
Owner

aome510 commented Mar 2, 2023

@ViniciusAndr can you pull the new change and try to see if it actually solves the issue?

@ViniciusAndr
Copy link
Contributor Author

@aome510 Ok I will test

@ViniciusAndr
Copy link
Contributor Author

@aome510 Your commit solved the issue

@aome510 aome510 merged commit 9e93b7a into aome510:master Mar 2, 2023
@ViniciusAndr ViniciusAndr deleted the windows_duplicate_keys branch March 2, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] Every keypress is duplicated
2 participants