Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the context page state's structure #25

Merged
merged 7 commits into from
Oct 31, 2021
Merged

Rewrite the context page state's structure #25

merged 7 commits into from
Oct 31, 2021

Conversation

aome510
Copy link
Owner

@aome510 aome510 commented Oct 31, 2021 •
edited
Loading

Brief description of changes

  • use PageState::Context as a combination of PageState::Browsing, PageState::CurrentPlaying
  • handle window state update logic and context data request logic in the ui::handle_page_state_change function

@aome510 aome510 force-pushed the rewrite-context-page-structure branch from 6317650 to ad3f546 Compare October 31, 2021 18:35
@aome510 aome510 merged commit 166407f into master Oct 31, 2021
@aome510 aome510 deleted the rewrite-context-page-structure branch October 31, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aome510