Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows]: Create dummy window to handle media control #261

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

rashil2000
Copy link
Contributor

Closes #259

The code is from the example in Souvlaki repository: https://github.com/Sinono3/souvlaki/blob/master/examples/print_events.rs

}
}

// demonstrates how to make a minimal window to allow use of media keys on the command line
Copy link
Owner

@aome510 aome510 Sep 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add note here mentioning that the windows handling code in this file is copied from https://github.com/Sinono3/souvlaki/blob/master/examples/print_events.rs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Owner

@aome510 aome510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look into this and implementing a fix

@aome510 aome510 merged commit f4d4501 into aome510:master Oct 1, 2023
@rashil2000 rashil2000 deleted the fix-hwnd branch October 1, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows]: Media control not working
2 participants