Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #454 overflowing of song title #529

Merged
merged 43 commits into from
Aug 4, 2024
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
c662594
Add config options for library section width
DOD-101 Jun 29, 2024
6c38580
Add check to config width values
DOD-101 Jun 30, 2024
abb8b92
Clean up code and rename config values
DOD-101 Jun 30, 2024
7b48c95
Add documentation for new config options
DOD-101 Jun 30, 2024
21f5935
Remove error handling code
DOD-101 Jul 10, 2024
6780cbe
Merge branch 'master' into add-278-2024-06-30
DOD-101 Jul 17, 2024
33153b5
skip single selection for artist actions (#507)
aNNiMON Jul 19, 2024
ea32a53
show album types in the artist context (#508)
aNNiMON Jul 19, 2024
e69394f
Fix mismatched arguments (#511)
aNNiMON Jul 19, 2024
bde96bd
Use BufReader/BufWriter for data from file cache (#510)
puuuuh Jul 19, 2024
742b307
New implementation of layout config
DOD-101 Jul 19, 2024
70f3b1a
Shortened config-option names
DOD-101 Jul 19, 2024
775c173
Add default method to LayoutConfig
DOD-101 Jul 19, 2024
ae01058
Merge branch 'master' into add-278-2024-06-30
DOD-101 Jul 19, 2024
945109b
Shorten library_page to library
DOD-101 Jul 20, 2024
319f0c2
Add docs/config.md section
DOD-101 Jul 20, 2024
14426e6
Add checks to ensure that Layout config values are valid
DOD-101 Jul 21, 2024
2b29b2a
Add CheckValues trait
DOD-101 Jul 21, 2024
0205300
Add artist layout options
DOD-101 Jul 21, 2024
1f96a12
Updated documentation
DOD-101 Jul 21, 2024
215ff5a
Move playback_window_position into layout
DOD-101 Jul 21, 2024
2a82e29
Move playback_window_width to layout.playback_window_height
DOD-101 Jul 21, 2024
102000d
Update docs
DOD-101 Jul 21, 2024
774196e
Code cleanup
DOD-101 Jul 21, 2024
6c15426
fix(docs): correct "width" to "height"
DOD-101 Jul 31, 2024
22353f2
fix(layout)!: fix overflowing of playback text
DOD-101 Jul 31, 2024
97ccc73
feat(config): add config option for height of title text
DOD-101 Jul 31, 2024
ca3cce2
fix(docs): remove redundant whitespace
DOD-101 Aug 1, 2024
107d0ea
fix(docs): remove old config options
DOD-101 Aug 1, 2024
1bcd970
fix(revert): revert accidental change
DOD-101 Aug 1, 2024
c08a32e
fix(revert): revert changes made to layout of pages other than library
DOD-101 Aug 1, 2024
d65328e
fix(docs): change "width" -> "percentage"
DOD-101 Aug 1, 2024
ab6b520
refactor(config): remove boilerplate code
DOD-101 Aug 1, 2024
d5d18c1
fix(revert): revert accidental deletion of line
DOD-101 Aug 1, 2024
7af00ec
refactor(suggestions): apply suggestions from code review
DOD-101 Aug 1, 2024
d38a292
feat(example): updated example app.toml
DOD-101 Aug 1, 2024
b382f23
Merge branch 'add-278-2024-06-30' into fix-454-2024-07-28
DOD-101 Aug 1, 2024
f16485d
feat(example): updated example app.toml
DOD-101 Aug 1, 2024
d0adfd5
docs(config): adjust wording
DOD-101 Aug 1, 2024
3cf789f
Merge branch 'master' into fix-454-2024-07-28
DOD-101 Aug 2, 2024
bfd3dc4
fix(mistake): remove text that accidentally showed up
DOD-101 Aug 2, 2024
c185bff
Revert changes
DOD-101 Aug 4, 2024
8d57e63
fix(ui): remove wrapping of text in playback window
DOD-101 Aug 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spotify_player/src/ui/playback.rs
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ pub fn render_playback_window(

if let Some(ref playback) = player.buffered_playback {
let playback_text = construct_playback_text(ui, track, playback);
let playback_desc = Paragraph::new(playback_text).wrap(Wrap { trim: false });
let playback_desc = Paragraph::new(playback_text);
frame.render_widget(playback_desc, metadata_rect);
}

Expand Down
Loading