Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of the User Preferences menu. #704

Closed
Oleg-Chashko opened this issue Nov 27, 2020 · 27 comments
Closed

Improvement of the User Preferences menu. #704

Oleg-Chashko opened this issue Nov 27, 2020 · 27 comments

Comments

@Oleg-Chashko
Copy link
Contributor

Why I think so:

  1. These lines are very long.
  2. When you open a setting from these lines, there is a lot of empty space.

Bildschirmfoto 2020-11-27 um 21 14 32

Bildschirmfoto 2020-11-27 um 21 17 56


Maybe you want to shorten them a little?
To be honest, I don't really like this option either.
But long ones are also not beautiful.
Example:
General
File Access
Extraction
Compression


Maybe it would be better this way?
Example:
macOS


P.S.: I'm sorry for interrupting. If you don't want to, please delete the topic. Thanks.

@gingerbeardman
Copy link
Contributor

Your prefs window is very wide.

Mine is only as wide as the icons in the toolbar:

Screen shot 2020-11-27 at 22 46 27

@oscargong
Copy link

oscargong commented Nov 28, 2020

CleanShot 2020-11-27 at 16 27 57@2x

It's even worse on my side, I cannot view the entire list of tabs on the same time, and this windows is not size adjustable.

@Oleg-Chashko
Copy link
Contributor Author

Your prefs window is very wide.

Mine is only as wide as the icons in the toolbar:

Screen shot 2020-11-27 at 22 46 27

@gingerbeardman
Keka v.1.2.4 (4287)
This came along with the macOS Big Sur design.
You're not on macOS Big Sur.
And because of this, a different design of windows.
This window is not adjustable in width.

@Oleg-Chashko
Copy link
Contributor Author

Oleg-Chashko commented Nov 28, 2020

CleanShot 2020-11-27 at 16 27 57@2x

It's even worse on my side, I cannot view the entire list of tabs on the same time, and this windows is not size adjustable.

@oscargong
You have macOS Big Sur. And you've installed Keka from the App Store.
I downloaded from github.com and I have no such problem.
I have this window wider than necessary.
Bildschirmfoto 2020-11-28 um 08 09 14

@aonez
Copy link
Owner

aonez commented Nov 28, 2020

@Oleg-Chashko provably you've opened Keka in German or Russian that use longer strings and the width stayed for English.

@oscargong I wasn't expecting that, even did a method that calculates the minimum width in every language to fit all buttons...

@gingerbeardman this is what I'm seen too 😂 no Big Sur for my normal day.

This windows is prepared to be resized so I'll enable it for the next revision and check all languages fit all buttons and longer languages don't get too wide.

Thanks to all!

@aonez aonez added this to the 1.2.5 milestone Nov 28, 2020
@Oleg-Chashko
Copy link
Contributor Author

Oleg-Chashko commented Nov 28, 2020

Joke: We must write correctly "macOS bug Sur"

@Oleg-Chashko
Copy link
Contributor Author

Oleg-Chashko commented Nov 28, 2020

@aonez

@Oleg-Chashko provably you've opened Keka in German or Russian that use longer strings and the width stayed for English.

Did the test:

  1. Deleted Keka -> Cleaned up the remaining Keka files in macOS.
  2. Installing Keka -> Language German -> First launch of Keka.
    Result:
    Stretched horizontally from the first launch.
    Question:
    The language did not switch but is there an error?

Bildschirmfoto 2020-11-28 um 10 04 09

Bildschirmfoto 2020-11-28 um 10 05 12

@Oleg-Chashko
Copy link
Contributor Author

This same experience only the system language is English, Keka's first launch.
Screenshot 2020-11-28 at 11 08 05
Screenshot 2020-11-28 at 11 08 35

@Oleg-Chashko
Copy link
Contributor Author

This same experience only the system language is Russian, Keka's first launch.
Снимок экрана 2020-11-28 в 11 20 30
Снимок экрана 2020-11-28 в 11 19 59

@Oleg-Chashko
Copy link
Contributor Author

@aonez

Provably you've opened Keka in German or Russian that use longer strings and the width stayed for English.

This theory has not been confirmed.

@aonez
Copy link
Owner

aonez commented Nov 30, 2020

@Oleg-Chashko this is definitely in Russian and German translation (and maybe others) that have very long strings. No need to delete Keka, simply the defaults:

defaults remove com.aone.keka

For example in German, as soon as you open the Compression pane it resizes to fit the "Use parent folder..." check.

I'm fixing this and @oscargong issue by making the Preferences windows resizable.

@aonez
Copy link
Owner

aonez commented Nov 30, 2020

Just noticed the advanced window toolbar is showing the labels by default in bug Sur...

Also @Oleg-Chashko there was an issue as well with the width, just affecting Big Sur as well.

I've fixed all of those in this build: Keka-v1.2.5-r4304

@aonez aonez added the fixed label Nov 30, 2020
@Oleg-Chashko
Copy link
Contributor Author

@aonez
I'll check it now and answer later.

@Oleg-Chashko
Copy link
Contributor Author

I do not know what to say. ʅ(°‿°)ʃ
It works well. But in my heart I want something else.
But I wanted to leave the normal fixed size of the settings window.
And so that long lines from one line form two lines.

Ohne Titel

@aonez
Copy link
Owner

aonez commented Dec 9, 2020

But I wanted to leave the normal fixed size of the settings window.

I prefer fixed too. Most probably will revert this change.

And so that long lines from one line form two lines.

Checkbox buttons are single line only...

What I can try is somehow center label-popupbuttons like Apple does in its preferences:

Screenshot 2020-12-09 at 12 10 35

@aonez aonez modified the milestones: 1.2.5, 1.3.0 Dec 9, 2020
@aonez aonez added some fixed and removed fixed labels Dec 9, 2020
aonez added a commit that referenced this issue Dec 9, 2020
@Oleg-Chashko
Copy link
Contributor Author

Hi @aonez

When you move the slider, the window is also stretched horizontally.

Untitled

P.S.: I switched to English, so as not to shake my nervous system. :)

@aonez
Copy link
Owner

aonez commented Dec 9, 2020

@Oleg-Chashko not sure what you're seeing there, I don't see the window resizing. Same in Big Sur.

Untitled mov

@Oleg-Chashko
Copy link
Contributor Author

@Oleg-Chashko
Copy link
Contributor Author

Oleg-Chashko commented Dec 9, 2020

@aonez
I apologize for not indicating which language at once.

@aonez
Copy link
Owner

aonez commented Dec 10, 2020

I'm not sure if fixing the size to fit the longest string or limiting the size of that label and truncate the string...

Screenshot 2020-12-10 at 16 33 09

And probably limiting the size and truncating the string is the best idea because it will work with all translations

Screenshot 2020-12-10 at 16 36 35

@aonez
Copy link
Owner

aonez commented Dec 10, 2020

Even using an smaller font size it does not fit without being too wide...

Screenshot 2020-12-10 at 16 42 00

@Oleg-Chashko
Copy link
Contributor Author

Yes, I understand you perfectly. To ask localizers to translate as compactly as possible in certain places, I think it is possible. Remove unnecessary words for localizers if possible. There is a problem with the German and Bulgarian languages, if I am not mistaken, perhaps in other languages.

@Oleg-Chashko
Copy link
Contributor Author

And probably limiting the size and truncating the string is the best idea because it will work with all translations.

Totally agree with you!

@Oleg-Chashko
Copy link
Contributor Author

As a possible solution to this problem. On Hovering the cursor, a window with the full text would pop up.
101793339-f66ac600-3b05-11eb-8ccb-892e88dc9db5

@Oleg-Chashko
Copy link
Contributor Author

Oleg-Chashko commented Dec 10, 2020

@aonez
Example:
Activate a window by hovering over it with the mouse.
Untitled

@aonez
Copy link
Owner

aonez commented Nov 20, 2021

I've refined the Preferences window size so it does not need to be resizable for 1.2.19.

@Oleg-Chashko
Copy link
Contributor Author

Checked, ok.

  • Keka v.1.2.50 (4808)
  • macOS v.12.0.1 (21A559)

Topic closed. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants