Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Korean translation #752

Merged
merged 2 commits into from
Jan 10, 2021
Merged

Update Korean translation #752

merged 2 commits into from
Jan 10, 2021

Conversation

sboh1214
Copy link
Contributor

No description provided.

@aonez
Copy link
Owner

aonez commented Jan 10, 2021

Thanks you so much! Don't you want to appear in the credits?

<!-- Korean -->
<span>
<h2>한국어</h2>
<span>JiHoon <a href="mailto:jihoongks@gmail.com">jihoongks@gmail.com</a></span>
<span>Lee, Kyutae <a href="https://github.com/gorisanson">@gorisanson</a></span>
</span>

@aonez aonez self-assigned this Jan 10, 2021
@aonez aonez added this to the 1.2.8 milestone Jan 10, 2021
@sboh1214
Copy link
Contributor Author

@aonez Thanks for notifying me about credits! I didn't know that :)

@aonez aonez merged commit 3eae687 into aonez:master Jan 10, 2021
@sboh1214 sboh1214 deleted the ko branch January 10, 2021 14:07
@aonez
Copy link
Owner

aonez commented Jan 11, 2021

@sboh1214 I just found this line:

"Error code %d using \"%@\"\n%@" = "Error code %d using \"%@\"\n%@";

I've received a translation from another user in the mail, and merged with the current translation, in case you want to check it out -> 6ab7154.

In those there're some strings not translated, maybe you can take a look at them 🧐:

"Keka has no file access to the source file/s\nGive it access when asked or manually in the Preferences" = "Keka는 원본 file/s 에 대한 파일 액세스 권한이 없습니다.\nPreferences(기본 설정)에서 요청하거나 수동으로 액세스 하십시오.";
"Give access to the source/s folder/s" = "source/s folder/s 에 대한 접근권한 허용";

@sboh1214
Copy link
Contributor Author

@aonez I'm glad there are many Korean translators. As you pointed out, I and Rockmc? didn't translate "Error code", "nPreferences" , and "source/s folder/s". I'll translate in my spare time and submit new PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants