Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Russian strings #967

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Fix Russian strings #967

merged 1 commit into from
Nov 16, 2021

Conversation

kytta
Copy link
Contributor

@kytta kytta commented Nov 16, 2021

That was hard considering how long some Russian words are 😅

@kytta
Fix Russian strings
bd3cee4 
Fix the length being over 45
@kytta kytta mentioned this pull request Nov 16, 2021
Merged
@hugonote
Copy link
Contributor

These lines would be on links/buttons, wouldn't they? So I think there should still be a verb of some kind.
It may sound better, but out of context it's not clear what it means.

@aonez
Copy link
Owner

aonez commented Nov 16, 2021 •
edited
Loading

They are titles and descriptions, not links :)

@hugonote
Copy link
Contributor

Okay, it's just that in my PR #968 I made edits to that section as well.
Since these are only descriptions, it is better to take them from this PR rather than mine.

@aonez aonez self-assigned this Nov 16, 2021
@aonez aonez added this to the 1.2.19 milestone Nov 16, 2021
@aonez
Copy link
Owner

aonez commented Nov 16, 2021

Thanks for the effort @NickKaramoff 👏🏼

@aonez aonez merged commit 68e795b into aonez:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aonez aonez

Labels
enhancement translation
Projects
None yet
Milestone
1.2.50
Development

Successfully merging this pull request may close these issues.
3 participants
@kytta @hugonote @aonez