Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chrome] add some libs to link for skia #20

Merged
merged 1 commit into from
Mar 6, 2023
Merged

[chrome] add some libs to link for skia #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions skia/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,21 @@ component("skia") {
libs = [ "fontsub.lib" ]
}

# FIXME:
# third_party/skia/src/gpu/ganesh/GrAHardwareBufferUtils.cpp
# which will call APIs from EGL/GLESv2 when built for android
# and API level >= 26
# These libs should be required for all ARCHs when following
# conditions are met.
# I'm not sure if this is an existing bug because I see
# these libs are added in third_party/skia/BUILD.gn.
if (is_android && android64_ndk_api_level >= 26) {
libs = [
"EGL",
"GLESv2",
]
}

# need separate win section to handle chromes auto gn filter
# (build/config/BUILDCONFIG.gn)
if (is_win) {
Expand Down